fix!: Change return type of GetDefaultCodeSecurityConfigurations
#3747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfy29
suggested changes
Oct 2, 2025
| "name":"config2", | ||
| "private_vulnerability_reporting": "enabled" | ||
| }]`) | ||
| "default_for_new_repos": "private", |
There was a problem hiding this comment.
private is not an allowed value here. See https://docs.github.com/en/rest/code-security/configurations?apiVersion=2022-11-28#get-default-code-security-configurations
There was a problem hiding this comment.
good catch :) fixed in latest commit
zyfy29
approved these changes
Oct 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3747 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 187 187
Lines 16702 16702
=======================================
Hits 15218 15218
Misses 1296 1296
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
changed the title
GetDefaultCodeSecurityConfigurations
gmlewis
added
the
Breaking API Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
GetDefaultCodeSecurityConfigurationsnow returnsCodeSecurityConfigurationWithDefaultForNewReposinstead ofCodeSecurityConfiguration.Modifies the return type of GetDefaultCodeSecurityConfigurations to match the response schema of the API.
Fixes: #3744.